raise Samlr::FormatError if the name_id is missing

zendesk / samlr

Clean room implementation of SAML for Ruby

Apache License 2.0

30 stars 12 forks source link

Closed kintner closed 8 years ago

kintner commented 8 years ago

@zendesk/secdev 🐙 @jcheatham @grosser

We are seeing some invalid saml responses without a name_id node.

Currently we crash by calling name_id_node.text on a nil name_id_node. This raises a Samlr::FormatError instead which we already handle.

jcheatham commented 8 years ago

👍

grosser commented 8 years ago

👍