Changed attributes hash to store keys by string and not also by symbols

zendesk / samlr

Clean room implementation of SAML for Ruby

Apache License 2.0

30 stars 12 forks source link

Changed attributes hash to store keys by string and not also by symbols #25

Closed mathurn-zz closed 7 years ago

mathurn-zz commented 7 years ago

@zendesk/secdev 🐙 @grosser

Changes the response.assertion.attributes method to return a hash that only contains String keys instead of duplicating them as symbols. This simplifies iterating over the hash.

grosser commented 7 years ago

can you explain why it was added ? .... ping who added it ?

kintner commented 7 years ago

@grosser @morten added it in the original commit: https://github.com/zendesk/samlr/commit/6279a1cbbd436643fb6d5e3c525c6c3f11412fbd

I wouldn't expect a library to implement a poor man's HashWithIndifferentAccess by adding both a string and symbol key.

This is a breaking change but its seems like the right behavior to me.

grosser commented 7 years ago

oh boy 2012 ... that @morten guy haunting us from the past :D