search

zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 234 forks source link

Possible to disable @channel from slack integration? #3693

Open benrudolph opened 4 years ago

benrudolph commented 4 years ago

The @channel is not desired in our use-case. Sometimes we're just deploying a branch to staging that doesn't have any PRs in it because we are just directly pushing to the branch. Is there a way to disable this @channel? Could argue that it'd be more flexible if it just used some unique word and then users could setup a notification based on that word if they wanted to. https://github.com/zendesk/samson/blob/71e4bb4e732efa919a8f07ec95196f6821984211/plugins/slack_webhooks/app/views/samson_slack_webhooks/notification.text.erb#L9

grosser commented 4 years ago

I'm fine with simply removing it ... it seems kinda noisy to do notifications for staging deploys anyway, that's why we never saw this problem :)

benrudolph commented 4 years ago

Nice, sounds great. We're a team of 4 so have reached any significant noise level yet :)