search

zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 234 forks source link

assets:precompile not generate env plugin assets #3948

Closed Willis0826 closed 3 years ago

Willis0826 commented 3 years ago

Issue

I ran RAILS_ENV=production PRECOMPILE=1 PLUGINS=all bundle exec rake assets:precompile --trace with v3290 can not generate env plugin assets under public/assets folder. Also, there are no error while running the command.

However, I can verify the v3260 work as expected.

Expected

I should be able to see env plugin assets after ran the precompile command.

How to reproduce

  1. git checkout v3290
  2. bundle
  3. RAILS_ENV=production PRECOMPILE=1 PLUGINS=all bundle exec rake assets:precompile --trace
  4. ls public/assets
  5. There is no env plugin
grosser commented 3 years ago

yeah, the add_assets_to_precompile hook is still getting called, but the fils are not rendered :/

grosser commented 3 years ago

found it ... it's an ordering problem :/

grosser commented 3 years ago

https://github.com/zendesk/samson/pull/3949

Willis0826 commented 3 years ago

Thanks for the quick response and fix : )