search

zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 234 forks source link

apply rails patches #4010

Closed Bing-Violet closed 2 years ago

Bing-Violet commented 2 years ago

Context

Security patches for a Rails have been released: https://rubyonrails.org/2022/4/26/Rails-7-0-2-4-6-1-5-1-6-0-4-8-and-5-2-7-1-have-been-released

grosser commented 2 years ago

thx, looks good! this test needs ❤️ 

rails test test/helpers/application_helper_test.rb:791
Bing-Violet commented 2 years ago

Hi Michael @grosser, I pushed some changes through, may I have another review on this again? Thank you in advance. :)

grosser commented 2 years ago

merged that in with https://github.com/zendesk/samson/pull/4011 🎉