zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 234 forks source link

Upgrade to ruby 3.0 #4062

Closed zendesk-mattlefevre closed 1 year ago

zendesk-mattlefevre commented 1 year ago

Description

The time has come: We're working on bumping Samson to Ruby 3.0

Risks

grosser commented 1 year ago

best do the gem upgrades in 1-off PRs to lower the risk / complexity🤞

grosser commented 1 year ago

unable to reproduce the cleanliness error (was unable to get 3.0 installed so I used 3.1, so maybe if that works bump to that ...)

grosser commented 1 year ago

oh ... it's a random error, ran it a few times and it fails :D

grosser commented 1 year ago

use this in test/integration/cleanliness_test.rb:8

- def all_models
+ let_all(:all_models) do