grosser
commented
1 year ago nice, thx for the details
On Tue, May 23, 2023 at 8:48 AM Matthew Lefevre @.***> wrote:
@.**** commented on this pull request.
In test/models/outbound_webhook_test.rb https://github.com/zendesk/samson/pull/4063#discussion_r1202589134:
webhook.auth_type = "Basic"webhook.username = "adminuser" webhook.password = "abc123"
- assert_equal connection.headers['Authorization'], 'Basic YWRtaW51c2VyOmFiYzEyMw=='
- assert_includes connection.builder.handlers, Faraday::Request::Authorization
I agree. Unfortunately, the faraday connection itself no longer has access to the authorization headers, so I'd have to completely rebuild the test to create a true request and look for the headers there.
— Reply to this email directly, view it on GitHub https://github.com/zendesk/samson/pull/4063#discussion_r1202589134, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACYZ27LNYKAC4EAPT4FCLXHTL27ANCNFSM6AAAAAAYMB657E . You are receiving this because your review was requested.Message ID: @.***>
Description
As part of upgrading Samson to Ruby 3.0, we want to break up gem upgrades into smaller, more testable chunks. This PR is to bump the
faradaygem, and all those that rely on it.Risks