zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 235 forks source link

fix: ignore 'RecreatingFailedPod' event reason for StatefulSets due to bug in 1.27 #4081

Closed a7i closed 6 months ago

a7i commented 10 months ago

Note: Samson is a public repo, do not include Zendesk-internal information, urls, etc.

In this PR, the behavior for pods being deleted while running was changed to be one of Succeeded or Failed. This makes sense for Jobs but not for StatefulSet. Currently, a rollout of StatefulSet leads to:

Warning RecreatingFailedPod: StatefulSet some-ns/some-pod-name is recreating failed Pod .... x59

The change is being cherry-picked to 1.27 mainline but not yet released.

References

Risks

a7i commented 8 months ago

addressed in 1.27.7