search

zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 235 forks source link

Upgrade rack-mini-profiler to v2.3.3 #4102

Closed rsb closed 7 months ago

rsb commented 7 months ago

Upgrade rack-mini-profiler to v2.3.3 to fix the ActionView::Template:Error (undefined method `safe_append=' for {:add_to_stack=>true}:Hash).

Followed the advice from here

Risks

grosser commented 7 months ago

ah nice I though I already had bumped that 🤦 ... maybe this + what just got merged to master will fix things

grosser commented 7 months ago

deployed to staging https://samson.zende.sk/projects/samson/deploys/2100282

grosser commented 7 months ago

streaming deploys seems to still be broken, but this is a good step forward

rsb commented 7 months ago

I will start troubleshooting that now