zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 234 forks source link

bump marco polo to fix warning #4103

Closed grosser closed 4 months ago

grosser commented 4 months ago

https://github.com/arches/marco-polo/pull/16#issuecomment-1942747103

@rsb

Risks

rsb commented 4 months ago

What's up with all the failing tests?

grosser commented 4 months ago

maybe need to require pry first or bump it too ... will revisit

rsb commented 4 months ago
➜ bin/rails s
Puma starting in single mode...
* Puma version: 5.6.8 (ruby 3.0.6-p216) ("Birdie's Version")
*  Min threads: 8
*  Max threads: 250
*  Environment: development
*          PID: 33673
! Unable to load application: NoMethodError: undefined method `new' for Pry::Prompt:Module
bundler: failed to load command: puma (/Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/bin/puma)
/Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/gems/3.0.0/gems/marco-polo-2.0.3/lib/marco-polo.rb:28:in `<main>': undefined method `new' for Pry::Prompt:Module (NoM
ethodError)
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:60:in `require'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:60:in `block (2 levels) in require'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:55:in `each'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:55:in `block in require'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:44:in `each'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler/runtime.rb:44:in `require'
        from /Users/robert.scottbuccleuch/.rbenv/versions/3.0.6/lib/ruby/3.0.0/bundler.rb:175:in `require'
        from /Users/robert.scottbuccleuch/Code/zendesk/samson/config/application.rb:24:in `<main>'
        from /Users/robert.scottbuccleuch/Code/zendesk/samson/config/environment.rb:3:in `require_relative'
        from /Users/robert.scottbuccleuch/Code/zendesk/samson/config/environment.rb:3:in `<main>'
        from config.ru:4:in `require_relative'
        from config.ru:4:in `block in <main>'
grosser commented 4 months ago

can't reproduce locally on 3.2 so I'll get that merged first and then revisit

rsb commented 4 months ago

Should I be testing locally on 3.2?

grosser commented 4 months ago

no, I just can't get 3.0 to run :D

grosser commented 4 months ago

rebased, should be fixed now 🤞