search

zendesk / samson

Web interface for deployments, with plugin architecture and kubernetes support
Other
1.45k stars 234 forks source link

commenting on pull requests comments on *all* pull requests #49

Open bhouse opened 10 years ago

bhouse commented 10 years ago

We ran into a scenario today where we stood up a fresh Samson instance, created a new project for a github repo, checked Update Pull Request after deployment, and ran a successful deploy.

Since it was the first successful deploy of the project, it covered the PR's for the life of the github repo, and commented on every PR that was already closed.

Some way to grandfather in old PR's on an initial deploy, or whatever, would be nice to avoid this. Consequently this github user, who shall remain nameless, has earned lots of comment points, if that is a thing.

bhouse commented 10 years ago

cc @zz85

bhouse commented 10 years ago

maybe the answer is just to have a successful deploy before checking the Update Pull Request after deployment box, so freeze that option until that happens?

jwswj commented 10 years ago

I like the idea that if a deploy hasn't happened before the integration wouldn't do anything.