search

zendesk / scala-flow

A lightweight library intended to make developing Google DataFlow jobs in Scala easier.
Apache License 2.0
14 stars 1 forks source link

Consider migrating from Joda Time to java.time #12

Closed ggrossman closed 7 years ago

ggrossman commented 7 years ago

From http://www.joda.org/joda-time/:

The standard date and time classes prior to Java SE 8 are poor. By tackling this problem head-on, Joda-Time became the de facto standard date and time library for Java prior to Java SE 8. Note that from Java SE 8 onwards, users are asked to migrate to java.time (JSR-310) - a core part of the JDK which replaces this project.

@dasch @ciaranarcher

dasch commented 7 years ago

We know, but the Dataflow SDK itself uses joda, so there's no way around it.

bcasey-zd commented 7 years ago

@ggrossman That's a reasonable suggestion and something we considered. It was surprising nearly 3 years after Java 8 has been released to find the Dataflow library still using Joda!

Unfortunately Joda is embedded deeply into the Dataflow SDK (and also in it's successor Apache Beam sigh...) which makes it confusing and difficult to use another date/time API

ggrossman commented 7 years ago

@bcasey-zd Understood; feel free to close this or keep it around for tracking if it's helpful

dasch commented 7 years ago

Closing it for now – we'll revisit it if Dataflow switches to java.time.