search

zendesk / setup-check-codeowners

A script to check .github/CODEOWNERS, and a GitHub Action to install it
MIT License
1 stars 2 forks source link

rubocop fixes #16

Closed zdrve closed 2 years ago

zdrve commented 2 years ago

Not yet introducing rubocop as part of CI, but that would be nice.

This doesn't fix all the problems. Just some. A step in the right direction.

bquorning commented 2 years ago

I’ve actually gotten to like the standard gem recently (at least on smaller projects like this one). It uses RuboCop under the hood, but enables (and configures) only a selection of the cops, and its opinions on config are pretty well argumented for.

I especially like the fact that it’s a tool that’s not meant to be configured. Maybe I’m just getting old 😬 See #17 for an example.