zendesk / setup-check-codeowners

A script to check .github/CODEOWNERS, and a GitHub Action to install it
MIT License
1 stars 2 forks source link

Extract code to a CheckCodeowners::CLI class #30

Open bquorning opened 1 year ago

bquorning commented 1 year ago

Seeing how slowly the specs were running, I decided to extract most of the code from main.rb into a CLI class. bundle exec rspec now runs in <3 seconds instead of >16 seconds.

I am not too happy about the current state of the code. I think root_path is being passed around too much, and perhaps I shouldn’t insist on it being a Pathname instance. Setting this PR as draft for now.