search

zendesk / ultragrep

the grep that greps the hardest.
Apache License 2.0
29 stars 4 forks source link

Achaturvedi/infr 393 #18

Closed aksharachaturvedi closed 10 years ago

aksharachaturvedi commented 10 years ago

This Pull request includes functionality to

  1. Parse the JSON production logs.
  2. Searching the logs.
  3. Pretty printing the logs.
  4. Searching based on the key for JSON filter. (not working if the key is INT else works fine)

@vanchi-zendesk

osheroff commented 10 years ago

checking in libjansson.a is not a solution - please go through ops to get them to add it (and its -devel package) onto the log servers.

aksharachaturvedi commented 10 years ago

Addressed the code review suggestions.

@vanchi-zendesk

vanchi-zendesk commented 10 years ago

@zenachaturvedi I suspect travis is failing because it's missing jansson. Can you add it to .travis.yml? http://docs.travis-ci.com/user/build-configuration/#Installing-Packages-Using-apt

aksharachaturvedi commented 10 years ago

Travis was failing before as some of the tests are not passing. But I'll surely look into adding Janson to travis.

vanchi-zendesk commented 10 years ago

:+1: