search

zendesk / ultragrep

the grep that greps the hardest.
Apache License 2.0
29 stars 4 forks source link

embed lua #32

Closed osheroff closed 10 years ago

osheroff commented 10 years ago

@vanchi-zendesk check this out -- we can replace rails_req.c (106 lines) with test.lua (25 lines) -- should make it much easier to write new format matchers (thinking I'll go ahead and do nginx logs, whynot). haven't yet taken a stab at the work-request logs.

about 50% slower than ug_guts.c (32s vs 22s to grep through a 1gb file).

also @shajith nya nya

osheroff commented 10 years ago

@vanchi-zendesk this stuff is ready for review. sorry for the huge size, dunno how I could have shrunk the PR

shajith commented 10 years ago

Congratulations on your sufficiently complicated program :)

vanchi-zendesk commented 10 years ago

Overall, this looks like a good rewrite. But now, I hate to say it, we have ruby + C + Lua.

osheroff commented 10 years ago

yeah, at some point if we get really really excited we should rewrite the ruby component in C. or rewrite the C component in go. or something.

vanchi-zendesk commented 10 years ago

+1 after eof is handled, tests pass.

vanchi-zendesk commented 10 years ago

+1