Helpful error messages if authentication fails

[joelhellman]

Expectations

I ran two commands that failed with two different outputs, but neither message indicated the root cause of authentication failure.

I expect that if I run a command that tries to authenticate to a Zendesk account, and the authenticate fails, the error messages should indicate that.

Reality

$ zcli apps:create
Uploading app... Failed
 ›   Error: Failed to upload app myapp

$ zcli apps:validate
 ›   Error: FetchError: invalid json response body at https://myapp.zendesk.com/api/v2/apps/validate reason: Unexpected token R in JSON at position 0

Steps to Reproduce

1. set env vars ZENDESK_SUBDOMAIN, ZENDESK_EMAIL, ZENDESK_API_TOKEN
2. have the ZENDESK_API_TOKEN be a value that results in failure to authenticate
3. try different zcli commands relying on authentication - does the error message indicates is an authentication failure?

Issue details

• Command: zcli apps:create zcli apps:validate etc
• Version: @zendesk/zcli/1.0.0-beta.8 wsl-x64 node-v14.17.0
• OS: OS: Ubuntu-20.04 on WSL v2. on Windows

[eric-at-nocoast]

Hey Joel,

Just following up to let you know I've seen this and will be logging this as an enhancement.