search

zendesk / zendesk_api_client_php

Official Zendesk API v2 client library for PHP
336 stars 259 forks source link

add support for listing articles for a specific section #341

Closed asifiqbal91 closed 7 years ago

asifiqbal91 commented 7 years ago

Add API support for getting articles list of a specific section.

REF: https://developer.zendesk.com/rest_api/docs/help_center/articles#list-articles

List Articles endpoints: GET /api/v2/help_center/sections/{id}/articles.json GET /api/v2/help_center/{locale}/sections/{id}/articles.json

kcasas commented 7 years ago

Hi @asifiqbal91,

Please create unit tests for the functionality you added and ensure travis build passes. For more info, please read our Contribution Guidelines.

Thanks for the interest :)

asifiqbal91 commented 7 years ago

Hi @kcasas I have updated some Test Cases. But travis build not passed yet. I am not so familiar this workflow.

Thank you. :-)

kcasas commented 7 years ago

@asifiqbal91 You can click on the red x button and view the travis console output from there. Here is the console output for one of the failed travis build. It seems that you are not following the PSR2 coding standard.

donjose24 commented 7 years ago

Hello @asifiqbal91 you can also click details down below to check where your tests are failing

asifiqbal91 commented 7 years ago

@jmramos02 It says, no environment variables set I am not good enough on TBD.

kcasas commented 7 years ago

@asifiqbal91 Got a closer look at the travis builds and it seems like the problem is not with your changes. I guess PSR2 got stricter this past few days and it affected some of the existing core code. I've created a PR #347 that fixes this. Sorry about that.

kcasas commented 7 years ago

@asifiqbal91 We've merge the PSR2 fixes. Rebase your branch for travis to go green.

asifiqbal91 commented 7 years ago

I got green on Pull #351 So, I am closing this pull request

asifiqbal91 commented 7 years ago

Hi @kcasas please check #351