search

zendesk / zendesk_api_client_php

Official Zendesk API v2 client library for PHP
336 stars 259 forks source link

Removes confusion of appending /token to usernames #358

Closed zanderwar closed 6 years ago

zanderwar commented 7 years ago

The Zendesk API docs state that if using a token, you should append /token to the username.

I myself personally appended /token to the username as there was no clarity without looking through the code that /token was appended automatically

This PR allows the user to both omit or include /token appendage

donjose24 commented 6 years ago

can you add test for this? :)

zanderwar commented 6 years ago

That's a negative, I don't have time to wrap my head around the way the tests are setup. Feel free to add it to this PR yourself by pushing to the patch-1 branch of zanderwar/zendesk_api_client_php

I've invited you as a collaborator ;P