Fixed PHP Doc of Attachments::upload()

zendesk / zendesk_api_client_php

Official Zendesk API v2 client library for PHP

336 stars 259 forks source link

Fixed PHP Doc of Attachments::upload() #415

Closed lyrixx closed 5 years ago

lyrixx commented 5 years ago

see https://github.com/zendesk/zendesk_api_client_php/blob/62e1f8488a78694fa88fe4c084a8c485a55f2824/src/Zendesk/API/Resources/Core/Attachments.php#L69-L71

lyrixx commented 5 years ago

@kcasas Hello. I don't understand what you did there. Do you need help?

kcasas commented 5 years ago

@lyrixx We have reports of tokens getting exposed on this repository. I've deleted them on the commit history by following this article https://help.github.com/en/articles/removing-sensitive-data-from-a-repository. The tool changed most of the commit hash and resulted to this change on your PR. I suggest you fork the repo again and make another PR.

lyrixx commented 5 years ago

@kcasas Thanks for the explanation. I have updated this PR. I hope i could be merged quickly.