search

zendesk / zendesk_api_client_php

Official Zendesk API v2 client library for PHP
336 stars 259 forks source link

Upgrade phpmd to latest version #440

Closed nogates closed 4 years ago

nogates commented 4 years ago

Description

Upgrade phpmd to latest version

sudo-plz commented 4 years ago

Why use a lock file anyway for a library? And if you need to use this version for phpmd, why not set in in composer.json?

nogates commented 4 years ago

@sudo-plz We use the lock file to ensure all developers use the same libraries versions when working with this library. The composer.lock file is ignored when using this library inside other applications.

And yes, I agree, we could have specifically require that version of the library. We may do that in the future. Thanks for the suggestion!

sudo-plz commented 4 years ago

@nogates Thanks for the clarification!