zendesk / zendesk_api_client_php

Official Zendesk API v2 client library for PHP
336 stars 259 forks source link

HttpClient warning on getting sideloads #456

Closed madkot closed 4 months ago

madkot commented 4 years ago

https://github.com/zendesk/zendesk_api_client_php/blob/8a2f44839fbbc9a1665d061aa6eb7b598aaf59c7/src/Zendesk/API/HttpClient.php#L441

i got error: Warning: array_merge(): Expected parameter 1 to be an array, string given in vendor/zendesk/zendesk_api_client_php/src/Zendesk/API/HttpClient.php on line 441

i think problem is when $sideload has 1 element, but array_merge needs more than 1, my temporary solutions is:

return count($sideloads) > 1 ? call_user_func_array('array_merge', $sideloads) : $sideloads;

ecoologic commented 5 months ago

Hi,

thank you for your request, are you still interested in a solution for this issue?

ecoologic commented 4 months ago

Closing due to inactivity. Re-open if needed.