search

zendesk / zendesk_api_client_php

Official Zendesk API v2 client library for PHP
336 stars 259 forks source link

Update Http.php #472

Closed RobinBoersma closed 12 months ago

RobinBoersma commented 3 years ago

Deprecated: stream_for will be removed in guzzlehttp/psr7:2.0. Use Utils::streamFor instead. Fixes #470

Gramzivi commented 3 years ago

There is a problem with this commit because it won't work in Guzzle versions from 6.0 to 7.1 as it is written in composer.json

jmwebslave commented 3 years ago

We too have run into this bug. While I agree it won't work in Guzzle 6.0-7.1 the problem is anyone pulling in the code now won't have it work. I'd suggest it's probably more critical to have it work for the current versions than it is for the old versions, since anyone running older versions won't have pulled this code anyway.

Gramzivi commented 3 years ago

I think maybe the safest solution, for now, is just to update the composer.json file according to working versions. If you have an existing project, a new composer install would mess your system. And tag new version with this update, to enable others to make difference between the old and new version of guzzle. But the problem is that Zendesk does not maintain this project anymore, so I don't know if anyone can merge updates.

schonhoff commented 2 years ago

I can't use Guzzle 1.x anymore because of other dependencies. Is there a solution without forking this package?

ecoologic commented 12 months ago

This solution has already been implemented. Thank you for your contribution.