Don't attempt to sideload with empty HTTP response body

zendesk / zendesk_api_client_rb

Official Ruby Zendesk API Client

http://developer.zendesk.com/

Apache License 2.0

387 stars 183 forks source link

Don't attempt to sideload with empty HTTP response body #357

Closed tonyhb closed 5 years ago

tonyhb commented 6 years ago

Sideloading fails with VCR during tests when attempting to iterate through keys of an empty response body.

tonyhb commented 6 years ago

I suppose the larger issue is 304 not modified responses being stored in VCR which occasionally fail - depending on the order and time that the tests were made in. need to poke around

nogates commented 5 years ago

@tonyhb Sorry it took a while to look at this. We have updated our test suite that uses VCR, and we haven't seen any error like that. is there a way you could provide an example of a response that causes this issue?