search

zendesk / zendesk_api_client_rb

Official Ruby Zendesk API Client
http://developer.zendesk.com/
Apache License 2.0
388 stars 183 forks source link

Revert "Bump v3.0.6 - Add Gemfile and Gemfile.lock for different Ruby versions" #570

Closed JinHuangAtZen closed 6 months ago

JinHuangAtZen commented 6 months ago

Reverts zendesk/zendesk_api_client_rb#568

JinHuangAtZen commented 6 months ago

I don't think we should revert versions that have already been made available to the public. We want all the 3.0.6 versions to be exactly the same code base.

It might be argued that this is only CI changes, so it was redundant to release a version in the first place, but what I would do at this point is just leave the main branch as is (closing this PR), and when we ship some value to the customers we can release a higher version.

Lastly, if we really wanted to undo a version release, we would have to delete the git tag and remove the version from rubygems, something I would do only if no-one ever downloaded the new version. -- Now I checked and noticed that we haven't even released 3.0.5 anyway in rubygems, so seems like the release process wasn't even followed to completion. 🤔 I don't think this changes my opinion about this PR. I suggest closing and moving on.

Yup, I didn't go ahead to release 3.0.5 because the issue we found, will close this PR for now.