zendesk / zendesk_app_migrator

CLI tool to assist in migrating v1 App Framework apps to v2
Other
10 stars 5 forks source link

[AF-788][BUG] Migrate CommonJS modules #22

Closed svizzari closed 7 years ago

svizzari commented 7 years ago

✌️ 🐛 🐛

/cc @zendesk/vegemite

Description

The work carried out in #13 didn't solve all the issues with migrating Common JS. @nick-f tested and found that require statements in app.js weren't being rewritten to include a relative path (to lib). With this change require("module.js") in app.js, will become require("./lib/module.js") in legacy_app.js when migrated.

Tasks

References

Risks

svizzari commented 7 years ago

@zendesk/vegemite 💇‍♂️ This now has tests, and is ready for review

svizzari commented 7 years ago

@danielbreves 💇