Added force_polling option into theme.rb - Githubissues

zendesk / zendesk_apps_tools

Apache License 2.0

74 stars 41 forks source link

Added force_polling option into theme.rb #374

Closed glook closed 2 years ago

glook commented 2 years ago

:v:

/cc @zendesk/vegemite

Description

Im using zendesk_app_tools via vm which mount volume via sshfs.

I see that you using listen gem to manage theme file changes.

Its readme says

some filesystems won't work without polling (VM/Vagrant Shared folders, NFS, Samba, sshfs, etc.)

Thats why I added --force-polling option into zat theme preview.

Tasks

[ ] Include comments/inline docs where appropriate
[ ] Write tests
[ ] Update changelog here

Risks

[HIGH | medium | low] Does it work on windows?
[HIGH | medium | low] Does it work in the different products (Support, Chat)?
[HIGH | medium | low] Are there any performance implications?
[HIGH | medium | low] Any security risks?
[HIGH | medium | low] What features does this touch?

token-cjg commented 2 years ago

Thanks for this contribution, it will go out in the next release of ZAT.