zendeskgarden / react-components

:seedling: garden React components
https://zendeskgarden.github.io/react-components/
Apache License 2.0
1.1k stars 89 forks source link

Dropdowns - Select, Multiselect components have accessibility violations #1376

Closed tepahk closed 1 year ago

tepahk commented 2 years ago

Expectations

Reality

Steps to Reproduce

  1. Visit https://zendeskgarden.github.io/react-components/?path=/story/packages-dropdowns-select--select
  2. View Accessibilty tab in Addons panel
  3. Observe violations
  4. Visit https://zendeskgarden.github.io/react-components/?path=/story/packages-dropdowns-multiselect--multiselect
  5. View Accessibilty tab in Addons panel
  6. Observe violations

Fine Print

This is not an exhaustive list of all violations, just a few we observed while extending Garden.

jzempel commented 2 years ago

@tepahk thanks for raising this issue. The Garden team is aware of the dropdown accessibility issues and has them on our radar as part of a larger component a11y sweep. I don't have a definite target timeframe for a fix. Stay tuned – we'll get back to you as plans materialize.

jessicachou commented 1 year ago

@jzempel this issue came up again recently in some web conversations, so do you have an update on the status or ETA for when this might get fixed? thanks!!

jzempel commented 1 year ago

@jessicachou we're on track to deliver a refactored <Combobox> component at the end of this month. In progress branch is here: https://github.com/zendeskgarden/react-components/tree/jzempel/combobox

jzempel commented 1 year ago

@tepahk the refactored Combobox is now available :tada:. Please see the following references for details: