zendeskgarden / react-components

:seedling: garden React components
https://zendeskgarden.github.io/react-components/
Apache License 2.0
1.1k stars 89 forks source link

refactor(forms): use transient props where appropriate #1952

Closed ze-flo closed 4 weeks ago

ze-flo commented 4 weeks ago

Description

This PR updates various components in react-forms to use transient props where appropriate. These changes are necessary in preparation for the upgrade to styled-components@6.x.x to ensure we avoid DOM violation errors after the transition.

Checklist

coveralls commented 4 weeks ago

Coverage Status

coverage: 95.896% (+0.001%) from 95.895% when pulling 46024ba291b39fab3df74d359a6f11fa291ecc48 on ze-flo/transient-props-forms into 30e06b0ae8b41de67d70bad897390ff8409aaa29 on main.

ze-flo commented 4 weeks ago

All snapshots tests in #1953 have passed. ✅

ze-flo commented 4 weeks ago

Snapshots are failing due to this change. This is expected and should be okay to merge.