zendframework / ZendService_Amazon

BSD 3-Clause "New" or "Revised" License
29 stars 37 forks source link

Updated QA toolchain #53

Closed weierophinney closed 9 years ago

weierophinney commented 9 years ago

Additionally, once the above were complete, ran php-cs-fixer without the --dry-run flag to fix CS issues.

Maks3w commented 9 years ago

append || return 0 to xdebug use 1.7.* as constrait of cs tool

weierophinney commented 9 years ago

@Maks3w —

append || return 0 to xdebug

Already did; see the most recent commit.

use 1.7.* as constrait of cs tool

~1.7.0 is functionally equivalent anyways (will install anything between 1.7.0 and 1.8.0, not including 1.8.0), and wildcards are frowned upon by the Composer team.

Maks3w commented 9 years ago

I don't like the DISABLE_XDEBUG config option. Alone does not have sense. Require to manual change when xdebug become available on PHP7 or HHVM

weierophinney commented 9 years ago

@Maks3w will the || return 0 correct for that? If so, send a PR removing the variable and the conditional.