zendframework / ZendService_Apple_Apns

BSD 3-Clause "New" or "Revised" License
49 stars 70 forks source link

Add mutable-content #56

Open juliangut opened 7 years ago

juliangut commented 7 years ago

aps message parameter should have a mutable-content key (starting with iOS 10)

Right now it can be added by using a custom parameter but it would be better to have it in its own attribute (getter/setter)

juliangut commented 7 years ago

I've just noticed #53

lostincode commented 7 years ago

@juliangut I think this has to be under the aps payload - so setting in custom will have no weight. #53 addresses this.

juliangut commented 7 years ago

@lostincode you're right. #53 addresses it the correct way.

This package seems to move sooooo slowly, that PR is from Nov 9th 2016

lostincode commented 7 years ago

@juliangut agreed. I hope someone will check it soon

laurent35240 commented 7 years ago

Does anybody have any news about when this PR will be validated?

fjalvarezdd commented 7 years ago

Please I need this attribute to be sent. Does anybody have checked it ? Thanks in advance,

laurent35240 commented 7 years ago

We used the forked project from the PR and it works fine for us. So I guess you can use it too

fjalvarezdd commented 7 years ago

Hello @laurent35240 thanks for your response. The problem is that I'm using https://github.com/Ph3nol/NotificationPusher to wrap Zend APNS / GCM service so I can not use the forked repo.

Thanks

laurent35240 commented 7 years ago

Yes we had exactly the same problem. We ended up forking both repositories: https://github.com/xofym/NotificationPusher https://github.com/xofym/ZendService_Apple_Apns

And put this configuration in our composer.json file in order to use our forked version

{
    "minimum-stability": "dev",
    "prefer-stable": true,
    "require": {
        "sly/notification-pusher": "dev-mutable",,
        "zendframework/zendservice-apple-apns": "1.2.2"
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:xofym/ZendService_Apple_Apns.git"
        },
        {
            "type": "vcs",
            "url": "git@github.com:xofym/NotificationPusher.git"
        }
    ]
}

I guess you can use the same configuration in your project

fjalvarezdd commented 7 years ago

@laurent35240 do you mind if I use your repo? That's exactly that we've in mind to do.

Thanks

laurent35240 commented 7 years ago

Sure you can use our repo. That's why I gave you our configuration in fact ;-)

fjalvarezdd commented 7 years ago

Hello @laurent35240 . Really appreciate it. I've just pointed to your repo and everything works as expected.

Thank you so much!

seyfer commented 7 years ago

@laurent35240 why not make pull requests?

laurent35240 commented 7 years ago

@seyfer Because they already exist ;-) They just take very long time to be validated (see #53)