search

zendframework / ZendService_Google_Gcm

Implementation for ZF2 of a GCM 3rd party server (http://developer.android.com/guide/google/gcm/)
BSD 3-Clause "New" or "Revised" License
29 stars 49 forks source link

Update composer.json #33

Closed akaneru closed 7 years ago

akaneru commented 7 years ago

Requirements updates in order to use the package with the version 3 of the framework.

akaneru commented 7 years ago

By accepting that PR will be able to work with this package also in ZF3. Thanks!

akaneru commented 7 years ago

Please, anyone can handle that PR? Thanks!

akaneru commented 7 years ago

Hi @mwillbanks, could you kindly handle that pull request? Thanks

akaneru commented 7 years ago

Hi @froschdesign, with the new composer.json / travis file we have new errors: iconv_set_encoding(): Use of iconv.internal_encoding is deprecated That's strange because it appears to be already resolved https://github.com/zendframework/zf1/issues/344 https://github.com/zendframework/zendframework/issues/6218 But maybe there's something that I'm missing or I don't know :| Could you give me some suggestion?

Thank you!

akaneru commented 7 years ago

Hi @froschdesign, please let me know what can I do to solve the issue. Best regards, tomaso

akaneru commented 7 years ago

Hi again, an other updates about the Travis CI fail: locally I could run tests with success (below the result).

vendor/bin/phpunit --color=always PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

.............................S..

Time: 46 ms, Memory: 6.00MB

OK, but incomplete, skipped, or risky tests! Tests: 32, Assertions: 108, Skipped: 1. `

Thank you

akaneru commented 7 years ago

Hello, I've found a way to solve the issue by removing the package from requirements, add adding it to the autoload section in composer json file. That allow me to update zend framework 3 and use it with the Gcm service.

{
    "require": {
        "php": "^5.6|^7.0",
        "zendframework/zendframework": "^3.0",
        "zendframework/zend-i18n": "^2.7",
        "zendframework/zend-mvc-plugin-flashmessenger": "^1.0",
        "zendframework/zendservice-apple-apns": "dev-master"
    },
    "autoload": {
        "psr-4": {
            "ZendService\\Google\\": "libraries/ZendService_Google_Gcm/library/"
        }
    }
}

Best regards.