search

zendframework / ZendService_Twitter

PHP OOP wrapper for the Twitter API
BSD 3-Clause "New" or "Revised" License
22 stars 23 forks source link

Finalize media and rate limit support #39

Closed weierophinney closed 7 years ago

weierophinney commented 7 years ago

This patch incorporates #34 in order to provide testing. A number of minor refactors were performed to simplify usage, provide consistency, and provide testability.

Additionally, per feedback from @Ocramius, this patch updates the component to target PHP 7.1+, allowing the code to provide scalar type hints and return type hints, which allows far simpler error handling and reduced maintenance overhead.

Ocramius commented 7 years ago

https://github.com/zendframework/ZendService_Twitter/pull/39/commits/5320b6c1e8ba950556fd76144a694dd102049f1a seems unrelated

A lot of these commits should be squashed due to their lack of description.

weierophinney commented 7 years ago

5320b6c seems unrelated

A lot of these commits should be squashed due to their lack of description.

I've now rebased off of develop, and squashed commits.

Ocramius commented 7 years ago

Thanks @weierophinney! I'll try doing another round of reviews soon.