search

zendframework / ZendSkeletonApplication

Skeleton application for zend-mvc projects
BSD 3-Clause "New" or "Revised" License
1.51k stars 1.42k forks source link

Update version number as part of build process #356

Open GeeH opened 8 years ago

GeeH commented 8 years ago

We need to to this as part of release but I have no idea how.

Suggestions.

Ocramius commented 8 years ago

Somebody backport and maintain ocramius/package-versions for PHP 5.x plz :trollface:

GeeH commented 8 years ago

Banning @Ocramius for blatant advertisment.

GeeH commented 8 years ago

On a serious note, would you have a problem with this repository having a dependency on ocramius/package-versions @weierophinney?

Ocramius commented 8 years ago

ocramius/package-versions is (purposely) 7.0.x only, but since it's MIT, anyone can just grab it and backport the functionality. As it stands, it's just about removing few type hints and strict type declarations

GeeH commented 8 years ago

It's easier if we just up the requirements of this skeleton application to 7.0.x.

stijnhau commented 8 years ago

That might be true but i think de dependcy on PHP-7 for the default app that 90% of people will start with is just to soon.

samsonasik commented 8 years ago

@Ocramius I forked your ocramius/package-versions and try to make it compatible to ^5.6 in my forked repo ( https://github.com/samsonasik/PackageVersions/pull/1 ) , would you mind to review ?

samsonasik commented 8 years ago

there is a samsonasik/package-versions now! a backport of ocramius/package-versions that support php 5.6 ;)

samsonasik commented 8 years ago

I've created PR #371 for it to use samsonasik/package-versions as backport of ocramius/package-versions that support php 5.6 ;)

weierophinney commented 6 years ago

And... despite having this and related issues open today... I forgot to bump the version when I released 3.0.3 a short bit ago, belying the need for this to be in place.

I'm still unsure how to proceed. The version constant approach does have use cases in terms of us helping understand where to start with a user, but typically the output of composer show will be far more relevant. Having that info in the browser could be useful, particularly for users who are uncomfortable with the command line and/or composer, but means an extra package that serves no purpose once the template is replaced.

In many ways, I think I'd rather just drop the version constant altogether. Thoughts?

michalbundyra commented 6 years ago

@weierophinney

In many ways, I think I'd rather just drop the version constant altogether. Thoughts?

As I remember correctly the idea to have the constant was for easier investigating issues with the skeleton, to help resolve reported issues. It is going to help only with issues only in the skeleton, not in dependencies, as I've mentioned already over a year ago https://github.com/zendframework/ZendSkeletonApplication/pull/371#issuecomment-234280706 and suggested there dropping the version constant.

Removing the version constant from the skeleton - YES from me 👍

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-skeleton-installer; a new issue has been opened at https://github.com/laminas/laminas-skeleton-installer/issues/3.