zendframework / maintainers

Contributors and maintainers information for Zend Framework.
BSD 3-Clause "New" or "Revised" License
50 stars 25 forks source link

Add travis template #16

Closed geerteltink closed 7 years ago

geerteltink commented 7 years ago

See #15.

This PR adds a template for Travis CI configuration to attempt to have a central location for templates and communication about possible future changes.

Currently when updating a project the way to have an up-to-date .travis.yml file is looking it up in the latest released package and copy the changes from there. This makes the example config available in a central place.

weierophinney commented 7 years ago

Maybe we should include in that template also variables and commands to deploy documentation.

I'm working on having zfbot build the docs. Since the bot gets triggered for build status events, it can trigger doc builds when it detects a successful build on the master branch. Doing this means we can remove such integration out of the Travis config - which has a nice side effect of preventing token exposure (our previous token was exposed a couple months ago; github revoked it for us when it was detected). It will also make triggering new builds when templates change far easier.

geerteltink commented 7 years ago

I'm working on having zfbot build the docs. Since the bot gets triggered for build status events, it can trigger doc builds when it detects a successful build on the master branch.

Exactly why I didn't include it. And more reason to have a centralized template as others didn't know about this yet.

froschdesign commented 7 years ago

Exactly why I didn't include it.

Exactly why these boilerplates so important, because all others didn't know this!

geerteltink commented 7 years ago

I'm not so happy with these 2 lines:

env:
  global:
    - LEGACY_DEPS="phpunit/phpunit"

install:
  - if [[ $TRAVIS_PHP_VERSION =~ ^5.6 ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi

They are not reusable. Can't we write it like this:

matrix:
  include:
    - php: 5.6
      env:
        - DEPS=lowest
        - LEGACY_DEPS="phpunit/phpunit"

install:
  - if [[ $LEGACY_DEPS != "" ]]; then travis_retry composer update $COMPOSER_ARGS --with-dependencies $LEGACY_DEPS ; fi

This way we can reuse it for any php version where needed.

froschdesign commented 7 years ago

@xtreamwayz

This way we can reuse it for any php version where needed.

Makes sense.

michalbundyra commented 7 years ago

I think we will need to set then LEGACY_DEPS only on locked build.

geerteltink commented 7 years ago

For tests and travis composer show output see xtreamwayz/xtreamwayz.com#20

weierophinney commented 7 years ago

Thanks, @xtreamwayz!