zendframework / maintainers

Contributors and maintainers information for Zend Framework.
BSD 3-Clause "New" or "Revised" License
50 stars 26 forks source link

Feature - conform templates script #26

Closed michalbundyra closed 6 years ago

michalbundyra commented 6 years ago

It should be called from main repository package:

$ zf-maintainer rebase-doc-templates <path-to-package>

It takes package name from composer "name" key.

I've used this script to prepare PR in all zend-expressive-* packages and tested also in couple others. Definitely we can improve it more, but as starter I think it's good enough ;-)

weierophinney commented 6 years ago

And... just for the record... I have created weierophinney/zf-component-template, which can be used when creating a new component. It is in-sync currently with this repository, and includes as self-removing setup.php script that does these same operations. It also provides a ConfigProvider class, and a test for that class, as a baseline for the new component.

This stuff could be moved into this repository as well. The main difference is that creation wouldn't be clone + setup, but instead just invoking the script.

weierophinney commented 6 years ago

According to wikipedia \n\r is possible somewhere:

Yes, RiscOS and Acorn BBS... which PHP doesn't support anyways. I mean, I suppose you could edit on these platforms and deploy to another platform, but it's unlikely.

I've been working with line-endings in PHP OSS projects for over a dozen years, and have literally never had anybody ask to support LF+CR. :smile:

weierophinney commented 6 years ago

With #28 merged, do you want me to merge this, or wait for you to refactor it to symfony/console?

michalbundyra commented 6 years ago

@weierophinney

With #28 merged, do you want me to merge this, or wait for you to refactor it to symfony/console?

I'm refactoring it now to use symfony/console. Will be ready shortly.

michalbundyra commented 6 years ago

@weierophinney It's now updated

weierophinney commented 6 years ago

Thanks, @webimpress!