zendframework / modules.zendframework.com

Home for ZF2 module distribution
BSD 3-Clause "New" or "Revised" License
189 stars 159 forks source link

Why can't display my module #202

Open dudapiotr opened 10 years ago

dudapiotr commented 10 years ago

Hi, I try to publish my new module but I can see either in modules nor in my organization... I've forked from organization to my profile and have the same.

Base module - https://github.com/HyPhers/visio-crud-zf2

Forked module https://github.com/dudapiotr/visio-crud-zf2

Could anyone tell me what am I doing wrong?

bacinsky commented 10 years ago

Same here

localheinz commented 9 years ago

@dudapiotr

If the module is a fork, it can't be added, and here's why:

if ($repository->fork || !$repository->permissions->push) {
    throw new Exception\UnexpectedValueException(
        'You have no permission to add this module. The reason might be that you are ' .
        'neither the owner nor a collaborator of this repository.',
        Http\Response::STATUS_CODE_403
    );
}

See ZfModule\Controller\IndexController::addAction().

localheinz commented 9 years ago

I'm not sure why that decision was made, but I have no objections to discussing it.

However, it's not a bug, it's a feature.

gianarb commented 9 years ago

In my opinion this is a good feature.. Only the owner can load your module into the site. @dudapiotr why do you not load this module from HyPhers org?

GeeH commented 9 years ago

Why are we not allowing forks to be added? Can someone explain in short words to me? Is it just because I could fork a repo and add it as my own? If this is the case then we need a "report module" mechanism.

There are genuine use cases where I can fork from another repo and modify heavily with attribution in place and want to submit my fork as a module. Leaving it as a fork allows my users to see where the project has come from and is an integral part of OS community, and disallowing forks to be added is wrong in my opinion.

localheinz commented 9 years ago

@GeeH

I think it would be great to show forks!

How about this:

Original and fork are registered

Fork is registered, original is not

What do you think?