zendframework / zend-cache

BSD 3-Clause "New" or "Revised" License
69 stars 53 forks source link

Modernize the package and finalize QA tooling #148

Closed weierophinney closed 6 years ago

weierophinney commented 6 years ago

This patch modernizes the package to follow guidelines as set in our maintainers repository.

In particular:

Additionally, this patch incorporates commits from #141 that accomplish the following:

weierophinney commented 6 years ago

Pinging @webimpress ...

weierophinney commented 6 years ago

Initial test runs that have actually completed (a number had segfaults and needed to be restarted) have been mostly successful, with one specific failure: the Cache\IntegrationTests\CachePoolTest::testHasItemReturnsFalseWhenDeferredItemIsExpired test case often fails. I suspect this is a timing issue primarily.

weierophinney commented 6 years ago

I honestly think at this point the only way we'll get tests to run completely is to separate the adapters into their own repos, as @marc-mabe has planned for some time.

michalbundyra commented 6 years ago

@weierophinney

Pinging @webimpress ...

Sorry, I was not able to have a look before... LGTM 👍 😄

thomasvargiu commented 6 years ago

@weierophinney About Cache\IntegrationTests\CachePoolTest::testHasItemReturnsFalseWhenDeferredItemIsExpired failed test, it's normal.

The Zend\Cache\Psr\CacheItemPoolAdapter adapter doesn't support driver deferred saves, so cache items are saved on destruct or on explicit commit() call.

I'm working on it and I'll open a PR to skip that test in a while.

thomasvargiu commented 6 years ago

Open #149