Closed weierophinney closed 6 years ago
Pinging @webimpress ...
Initial test runs that have actually completed (a number had segfaults and needed to be restarted) have been mostly successful, with one specific failure: the Cache\IntegrationTests\CachePoolTest::testHasItemReturnsFalseWhenDeferredItemIsExpired
test case often fails. I suspect this is a timing issue primarily.
I honestly think at this point the only way we'll get tests to run completely is to separate the adapters into their own repos, as @marc-mabe has planned for some time.
@weierophinney
Pinging @webimpress ...
Sorry, I was not able to have a look before... LGTM 👍 😄
@weierophinney About Cache\IntegrationTests\CachePoolTest::testHasItemReturnsFalseWhenDeferredItemIsExpired
failed test, it's normal.
The Zend\Cache\Psr\CacheItemPoolAdapter
adapter doesn't support driver deferred saves, so cache items are saved on destruct or on explicit commit()
call.
I'm working on it and I'll open a PR to skip that test in a while.
Open #149
This patch modernizes the package to follow guidelines as set in our maintainers repository.
In particular:
/doc/
to/docs/
.composer.json
structure..gitignore
,.gitattributes
, etc.)Additionally, this patch incorporates commits from #141 that accomplish the following:
PatternPluginManager
to ensure it works with both v2 and v3 versions of zend-servicemanager, fixing an issue with PHP 7.2 compatibility.