search

zendframework / zend-cache

BSD 3-Clause "New" or "Revised" License
69 stars 53 forks source link

Fixed typo in variable name #168

Closed peterprototypes closed 6 years ago

peterprototypes commented 6 years ago

There was a typo in setTags in the filesystem adapter.

peterprototypes commented 6 years ago

@webimpress You're right, this would've been caught if there was a test case that passes an empty array for tags. I'm off today, but I'll add a test case this evening or tomorrow for this.

Off topic: I made a Redis adapter that supports tags for one of our projects. Should I make a PR?

michalbundyra commented 6 years ago

@ptodorov0123

but I'll add a test case

Cool, thanks 👍

I made a Redis adapter that supports tags for one of our projects. Should I make a PR?

Sure, create PR 😄

weierophinney commented 6 years ago

Thanks, @ptodorov0123!