zendframework / zend-cache

BSD 3-Clause "New" or "Revised" License
69 stars 53 forks source link

Issue #185 : replacing deprecated delete() calls with del() #186

Closed ppaulis closed 5 years ago

ppaulis commented 5 years ago

Fixing Issue #185 Since redis extension 5.0.0, Deprecation errors are thrown on every Redis::delete() call. Replacing the delete() calls with del() calls fixes these messages.

michalbundyra commented 5 years ago

@ppaulis Please see PR I've created to your branch: http://github.com/ppaulis/zend-cache/pull/1 All tests there pass! :)

tigrantv commented 5 years ago

@ppaulis , @webimpress please prepare and push these changes to release

pimjansen commented 5 years ago

@webimpress i dont really think this is an enhancement but a bug which is blocking a lot nowadays?

Ocramius commented 5 years ago

Not a bug: needs to indeed land in a new minor, since we are adding compatibility with a new tool, not fixing a bug here.

michalbundyra commented 5 years ago

As @boesing checked del() is available since 2.1.0 release. Ref:

and the latest version available on PECL is 2.2.3: https://pecl.php.net/package/redis

There is no need to add any conflict.

michalbundyra commented 5 years ago

Thanks, @ppaulis!