[BC Break] Remove annotations support for 4.0

zendframework / zend-code

BSD 3-Clause "New" or "Revised" License

1.68k stars 79 forks source link

[BC Break] Remove annotations support for 4.0 #153

Closed lisachenko closed 6 years ago

lisachenko commented 6 years ago

This PR removes annotations API for 4.0 as proposed by @Ocramius in https://github.com/zendframework/zend-code/issues/32 Also removed the zendframework/zend-eventmanager dependency.

[x] Remove all annotation API from classes
[x] Remove all annotation related classes and tests from the library
[x] Remove zendframework/zend-eventmanager dependency
[x] Rebase on develop branch
[x] Regenerate composer.lock file
[x] Document changes in the CHANGELOG.md
[x] Investigate build failure in the test https://travis-ci.org/zendframework/zend-code/jobs/364674886

Ocramius commented 6 years ago

@lisachenko since this patch targets the next release, it should be based off develop

lisachenko commented 6 years ago

Added several tasks into the check list

lisachenko commented 6 years ago

BTW, should we define a 3.x from the develop branch and push it only with deprecation notices for annotation API?

Ocramius commented 6 years ago

Not really needed tbh, as the user-base for annotations in here is quite narrow (I know of this mostly because I never receive any bug reports about annotations ;-) )

lisachenko commented 6 years ago

Awaiting approval on this PR

Ocramius commented 6 years ago

@weierophinney if you are ok with this I'll start pushing for 4.x overall.

weierophinney commented 6 years ago

@Ocramius Totally on board!

Ocramius commented 6 years ago

Alright, I suppose I need to revive some patches here over the next weekend :P

lisachenko commented 6 years ago

Alright, I suppose I need to revive some patches here over the next weekend :P

Ok, let's proceed with strict types then and bump PHP version)