search

zendframework / zend-code

BSD 3-Clause "New" or "Revised" License
1.68k stars 78 forks source link

Deprecate scanner functionality (4.0), drop it (5.0) in favor of #91

Open Ocramius opened 8 years ago

Ocramius commented 8 years ago

Basically, parsing via regexes is simply not acceptable/viable anymore, and absolutely doesn't scale, as the syntax of PHP keeps changing.

@asgrim has been building https://github.com/Roave/BetterReflection since last year, and the library is stable/mature, so I'd suggest that we chop the head off this part of zend-code's functionality.

Thoughts?

asgrim commented 8 years ago

No problem here, that's the sort of thing BR can do I believe (though I'm not intimately familiar with the scanner here). If there is missing functionality in BR, I'm happy to take PRs or feature requests.

weierophinney commented 8 years ago

I'm :+1: for this. While I've been happy we've had this feature in zend-code, it's difficult to maintain, and, particularly with the fast pace of language additions/changes, hard to keep up-to-date. The only way we could accomplish that is with a rewrite to use an AST and/or tokenization approach (the latter of which BR uses, IIRC), which would be a significant undertaking. Since another tool exists, I'd be happy to point folks to that instead.

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at https://github.com/laminas/laminas-code/issues/17.