PSR-12 ruleset - Githubissues

zendframework / zend-coding-standard

Zend Framework Coding Standard

BSD 3-Clause "New" or "Revised" License

35 stars 8 forks source link

PSR-12 ruleset #22

Closed geerteltink closed 4 years ago

geerteltink commented 4 years ago

This PR updates dependencies, uses PSR-12 as the base ruleset and refactors the ruleset and test into the PSR-12 documentation format. Some rules had to be left out or replaced as they conflict with the PSR-12 base ruleset.

[x] Update dependencies
[x] Import additional rules
[x] Import array rules
[x] Import string rules
[x] Import phpdoc and commenting rules
[x] Update docs
[x] Update to phpcs 3.5.1

resolves #18 resolves #19

weierophinney commented 4 years ago

Ping me when you've finished the todo items, as I'd love to review this!

geerteltink commented 4 years ago

@weierophinney and @webimpress PR is ready for review.

geerteltink commented 4 years ago

@weierophinney applied changes as requested, waiting for https://github.com/zendframework/zend-coding-standard/pull/22#discussion_r342191335 and https://github.com/zendframework/zend-coding-standard/pull/22#discussion_r342197516.