Zend Coding Standard 2

[geerteltink]

This PR adds a stricter ruleset. #1 is adding a lot of extra code and custom rules which are hard to maintain and it's so huge that it is hard to review. The huge amount of work done in #1 is not lost and is moved to webimpress/coding-standard.

The purpose of this PR is to start over and importing rules from other packages where possible.

• [x] Create new structure
• [x] Make the ruleset auto discoverable so it can be used globally with phpcs -s --standard=ZendCodingStandard src
• [x] Import slevomat/coding-standard rules
• [x] REVIEW PHASE: The rules need to be reviewed before the documentation is being written
• [x] Remove rules that are too strict for zendframework
• [x] Add tests
• [x] Write documentation for https://docs.zendframework.com/zend-coding-style/
• [x] Document deprecated changes: ignore parts in 4.0
• [x] Add a CHANGELOG.md entry
• [ ] Test code style on existing packages
  • https://github.com/zendframework/zend-diactoros/pull/331

Blocked by:

• [x] Poll: To align or not to align!
• [x] https://github.com/slevomat/coding-standard/issues/477 fixed in 4.8.0
• [x] https://github.com/slevomat/coding-standard/issues/478 fixed in 4.8.0
• [x] Aligning double arrows in arrays

Testing

Make sure you remove the global installation after testing from your global composer.json file!!!

$ composer global config repositories.zend-coding-standard vcs git@github.com:xtreamwayz/zend-coding-standard.git
$ composer global require --dev zendframework/zend-coding-standard:dev-feature/new-rules

# For this to work, add this to your path: ~/.composer/vendor/bin
# Using `-s` prints the rules that triggered the errors so they can be reviewed easily
$ phpcs -sp --standard=ZendCodingStandard src

# Automatically fixing errors
$ phpcbf -sp --standard=ZendCodingStandard src

[geerteltink]

@mwop @froschdesign I've fixed the issues, added tests and I'm now working on the docs. 70 files is a lot, but it's still only 1 ruleset file and the rest is tests and documentation.

[weierophinney]

@xtreamwayz I'll try and review over the weekend; Monday at the latest.

[geerteltink]

All documentation is added. I've left plenty of typo's, inconsistencies and mistakes for others to discover 😁

Some rules in the ruleset.md file still need examples.

/cc @mwop, @froschdesign

[geerteltink]

Merged into develop