zendframework / zend-component-installer

Composer post-package-(un)install scripts for modules and components.
BSD 3-Clause "New" or "Revised" License
46 stars 20 forks source link

Migration from Zend\Expressive\ConfigManager to Zend\ConfigAggregator #30

Closed gabbydgab closed 7 years ago

gabbydgab commented 7 years ago

Small change but backwards incompatible

Replacing mtymek/expressive-config-manager with zend-config-aggregator will cause bc breaks with existing applications consuming this package due to its (official) NAMESPACE (Zend\ConfigAggregator) - even though they are almost identical library.

Following change would be:

Zend\Expressive\ConfigManager\ConfigManager::class => Zend\ConfigAggregator\ConfigAggregator::class
Zend\Expressive\ConfigManager\PhpFileProvider => Zend\ConfigAggregator\PhpFileProvider

Why Zend\ConfigAggregator?

While designed for Expressive applications, it can work with any PHP project for aggregating and returning merged configuration, from either a variety of configuration formats or "configuration providers", invokable classes returning an array of configuration (or a PHP generator). It also supports configuration caching.

See: https://github.com/zendframework/zend-config-aggregator

What needs to be done?

weierophinney commented 7 years ago

I'll update it to manage both, as that way those who are already using the original ConfigManager will still be able to use the functionality.

Thanks for creating the issue!