New OpenSSL symmetric adapter + bcrypt refactor for PHP 5.5+

zendframework / zend-crypt

Cryptographic component from Zend Framework

BSD 3-Clause "New" or "Revised" License

90 stars 38 forks source link

New OpenSSL symmetric adapter + bcrypt refactor for PHP 5.5+ #25

Closed ezimuel closed 8 years ago

ezimuel commented 8 years ago

This PR contains the new OpenSSL symmetric adapter for zend-crypt ver. 3.0. We used this new adapter instead of Mcrypt in FileCipher and we suggested to use it in the documentation for all the other encryption needs. Mcrypt is an outdated extension and it will be deprecated) with PHP 7.1.

Moreover, this PR contains the Zend\Crypt\Password\Bcrypt refactor using the password_hash() and password_verify() functions of PHP 5.5+.

I updated the documentation according to these changes.

Note: All the changes included in this PR are backward compatible. I provided some unit tests as proof.

ezimuel commented 8 years ago

@weierophinney this PR is ready to be merged in develop, thanks!

weierophinney commented 8 years ago

@ezimuel Looks very good! Just a few general notes:

In a number of tests, you mark them skipped if specific extensions are missing and/or functionality is missing. I think for the purposes of testing and for Travis, we should likely mark those as failed, as they're required for the tests.
Last item of all arrays should have a trailing comma (reduces the impact of diffs when items are added later).
Update the copyrights across the board.
Make sure you're using sprintf() when generating exception messages with dynamic elements.

I've added more specific notes elsewhere. Nice work!

ezimuel commented 8 years ago

@weierophinney and @samsonasik I updated the PR will all your feedback, thanks!

weierophinney commented 8 years ago

Merged to develop! We can tag 3.0 early next week, @ezimuel !