search

zendframework / zend-crypt

Cryptographic component from Zend Framework
BSD 3-Clause "New" or "Revised" License
90 stars 38 forks source link

Use FQFN #50

Closed snapshotpl closed 6 years ago

snapshotpl commented 7 years ago

This repository use many internal php function. For example in my application when I use Zend\Crypt\BlockCipher class hash_hmac function is call 10k times and take ~23ms! This change should have perfomance visible impact

snapshotpl commented 7 years ago

@webimpress Is it an "official" way to do that in zf?

michalbundyra commented 7 years ago

Hm... I just only know that we have done this way in zend-code: https://github.com/zendframework/zend-code/pull/121 and zend-service as I've mentioned before. Both PR were merged and released. I would then go this way and import these functions. As I mentioned you can use my sniff, which will do all for you automatically 😄

weierophinney commented 6 years ago

Thanks, @snapshotpl!