Fixes #316 : set return null for HydratingResultSet::current() on no data

zendframework / zend-db

Db component from Zend Framework

BSD 3-Clause "New" or "Revised" License

101 stars 122 forks source link

Fixes #316 : set return null for HydratingResultSet::current() on no data #325

Open samsonasik opened 6 years ago

samsonasik commented 6 years ago

Provide a narrative description of what you are trying to accomplish:

[x] Are you fixing a bug?
- [x] Detail how the bug is invoked currently. call HydratingResultSet::current() on no data in current record.
- [x] Detail the original, incorrect behavior. it returns false.
- [x] Detail the new, expected behavior. it returns null, the "AbstractResultset" and "ResultSet" class returns null on no data, so it returns null for consistency/fix.
- [x] Base your feature on the master branch, and submit against that branch.
- [x] Add a regression test that demonstrates the bug, and proves the fix.
- [x] Add a CHANGELOG.md entry for the fix.

If this is considered a BC break, I can target to develop. Fixes #316

ezimuel commented 6 years ago

@samsonasik yes, this is a BC break. Please send it to develop. Thanks!

samsonasik commented 6 years ago

@ezimuel I've rebased against develop branch and change target to develop branch.

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/30.

weierophinney commented 4 years ago

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

Squash all commits in your branch (git rebase -i origin/{branch})
Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
Run the laminas/laminas-migration tool on the code.
Clone laminas/laminas-db to another directory.
Copy the files from the second bullet point to the clone of laminas/laminas-db.
In your clone of laminas/laminas-db, commit the files, push to your fork, and open the new PR. We will be providing tooling via laminas/laminas-migration soon to help automate the process.