search

zendframework / zend-db

Db component from Zend Framework
BSD 3-Clause "New" or "Revised" License
101 stars 122 forks source link

Refactor of `Zend\Db\Sql` for 3.0.0 #362

Open ezimuel opened 5 years ago

ezimuel commented 5 years ago

This is a task for refactoring Zend\Db\Sql using the type hints of PHP 7.2. You must work on the 3.0.0 branch.

If you change the API you should report it in the /3.0.0.md file.

Note: it's quite difficult to provide this code refactor without changing other classes. That means you should provide the refactoring without pass all the unit tests. In this phase is only important to have the unit tests running, so we you must focus only on fatal/parse errors.

guidofaecke commented 5 years ago

I might take a look at it.

ezimuel commented 5 years ago

Thanks @guidofaecke, let me know if you need some help!

arueckauer commented 5 years ago

@guidofaecke Do you want any assistance?

guidofaecke commented 5 years ago

You're more than welcome!

Here is what I got so far -> (https://github.com/guidofaecke/zend-db/tree/3.0.0_SQL_typeHints) It's not a lot, I know, but I'm busy with some work related projects as well :smiley:

arueckauer commented 5 years ago

That's alright. Me working on a separate fork is unmanageable and PRs are overkill IMO. Would it be okay, if you grant me contribution access to your repo?

guidofaecke commented 5 years ago

Done... I think... :laughing:

weierophinney commented 4 years ago

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/19.