Open arueckauer opened 5 years ago
This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/13.
This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:
git rebase -i origin/{branch}
)
This PR provides changes described in #365
A few questions came up while refactoring. Some feedback is appreciated:
ColumnObject
andConstraintKeyObject
). Since there are fluent setters, possibility is that they are being used. Therefore I recommend to unify and make all setters fluent. If that is okay, I'll provide the changes in this scope.ConstraintKeyObject
andAbstractSource
are used. Currently the visibility is defined aspublic
. If they are not needed elsewhere,private
orprotected
might be more suitable.$table
parameter ofloadConstraintData()
andloadConstraintReferences()
in classZend\Db\Metadata\Source\AbstractSource
is unused. Version 3.0 might be a good time to remove it (causing BC). Should I include this change in this scope?